GP32 Squidgesdk For Ads


Status
Not open for further replies.
Code:
> Here's the SDK I'm currently working with for ArmADS. It's a derivative work of MirkosSDK071. I can't really call it a port, because it's not compatible with his. 

Huhhh, 95% copy+paste, yehh a derivative work...

1) why are you not creating a compatible port ?
   I think the coderz want somthing compatibel, so they
   can try ads and gcc compiler on the same source.

2) if youre not satified with some of my code, or think you can improve
   something, why not talk to me, iam always open for suggestions.

3) changing line: 
   u16 gp_ButtonResult(void) {
 to
   u16 gp_ButtonResult(void)
   {

and putting a big 
// Modified 04/05/04 Squidge
over the file. Is really a big modification...

You got my permission to use my stuff, in the hope we result in a 
compatibel SDK for linux/windows_gcc/windows_ads ...
Iam a little disapointed...
 
I'm sorry if you disapprove of my version. Yes, it's 95% your code, but I don't want to give the impression to people that it's simply a version of your SDK compatible with ADS, hence why I called it a "derivative work". I put the "modified" text in to tell people looking at the code that it was not the original, regardless of how small, or how large the modification was.

If you don't like me using your code in this way, please tell me, and I will remove it from this site, and keep it private.
 
> but I don't want to give the impression to people that it's simply a version of your SDK compatible with ADS

I really dont know, why you dont want to work with me together, creating a compatible SDK for gcc and ads ?

1)if you want to port my SDK to ads, and only make changes, so it will compile on ads, youre welcome to use my work.

2)if you use my work, to create your own SDK, incompatibel from my SDK, i must ask you to keep your work private.

I think working 6 Month on this Project, and getting it to this stage, was a hard way. And i really dont like the idear " copy all my files, change some lines, make it incompatible, put a new name over it, ready is a new SDK "
 
Personally, I thought that it was enough to leave your credits in all the files so people knew where it come from, and then state clearly on my post that it was based on your SDK. However, since you don't like this idea, I'll remove it from the site.

I would like to know however how much of it is actually your own work. The chatboard source code is mainly from Mr Spiv, I wouldn't be suprised if you pulled 95% of grafik.c from somewhere else considering how similar it is to other code on the web, gp_irq.S is so similar to other pd code it's scary. DMA routines are in abundance, SMFS is simply the Samsung source code from Darkfaders website, and Zlib is also public domain.

The means that the main code you have probably written yourself is just the button code, font code, sbox, sound & sprite (and of course the examples & documentation). Is this true? I'd just like to know so I remove the offending files and routines.
 
Squidge posted on May 8 2004 at 08:43 PM said:
Personally, I thought that it was enough to leave your credits in all the files so people knew where it come from, and then state clearly on my post that it was based on your SDK. However, since you don't like this idea, I'll remove it from the site.

I would like to know however how much of it is actually your own work. The chatboard source code is mainly from Mr Spiv, I wouldn't be suprised if you pulled 95% of grafik.c from somewhere else considering how similar it is to other code on the web, gp_irq.S is so similar to other pd code it's scary. DMA routines are in abundance, SMFS is simply the Samsung source code from Darkfaders website, and Zlib is also public domain.

The means that the main code you have probably written yourself is just the button code, font code, sbox, sound & sprite (and of course the examples & documentation). Is this true? I'd just like to know so I remove the offending files and routines.
Why are you getting so rought...


and why cant you just answer one Question ?
"I really dont know, why you dont want to work with me together, creating a compatible SDK for gcc and ads ?"


> The chatboard source code is mainly from Mr Spiv
the *.c file is 100% written by me, if you want to check it, get his source for official sdk.

> 95% of grafik.c
complete written by me, with help from official arm pdf.

> gp_irq.S ,
yes this code is not from me, its from some old spivys code.

> DMA routines are in abundance
written by me

> SMFS is simply the Samsung source code
true, iam writing a FAT12/16 driver, until its not ready, i leave it in.
but the gp_ stuff is of couse from me. ( glibc file stuff, reading writing, directory stuff ) As this is a BIG part, it will take its time.

> and Zlib is also public domain.
true, i created the ZDA data format, and wrote the compressor, and the Documentation, how to do this... ( took me over 3 weeks to do this )

But you are talking about parts, you have not added, you added all common stuff from me !

All this files are written by me, with random help in #gp32dev chat.
gp_buttons.c gp_grafik.c gp_memory.c gp_arm.S gp_cpuspeed.c gp_timer.c
 
Last edited by a moderator:
I'm not getting rough, just asking a question about what files you wrote, so I can delete them from my sdk and rewrite. Thanks for the answer.

"why you dont want to work with me together, creating a compatible SDK for gcc and ads ?"

Because what you want is not what I want. From your code I can clearly see we have totally different coding styles, thoughts about how things should work, and what things should be in a SDK. I'm not interested in chatboard, sprites, timers and sound routines, which is why I left them out (I prefer to do things like that on a per-project basis). I didn't like the way your dma routines worked, so I changed them. I changed the rest of your routines to more closely match my coding style. It took me almost 2 days to convert your SDK over to ADS because of the way the code was written, the lack of prototypes, assuming the user was using GCC, etc. Working together is just not going to work out, therefore it would be best if we went different ways from now on, and not use any of each others code.
 
Squidge posted on May 8 2004 at 10:14 PM said:
I'm not getting rough, just asking a question about what files you wrote, so I can delete them from my sdk and rewrite. Thanks for the answer.

"why you dont want to work with me together, creating a compatible SDK for gcc and ads ?"

Because what you want is not what I want. From your code I can clearly see we have totally different coding styles, thoughts about how things should work, and what things should be in a SDK. I'm not interested in chatboard, sprites, timers and sound routines, which is why I left them out (I prefer to do things like that on a per-project basis). I didn't like the way your dma routines worked, so I changed them. I changed the rest of your routines to more closely match my coding style. It took me almost 2 days to convert your SDK over to ADS because of the way the code was written, the lack of prototypes, assuming the user was using GCC, etc. Working together is just not going to work out, therefore it would be best if we went different ways from now on, and not use any of each others code.
>I'm not getting rough, just asking a question about what files you wrote, so I can delete them from my sdk and rewrite. Thanks for the answer.

To keep it easy, the zlib folder and the gp_irq.S file is not my work.
So you can use them...


>I didn't like the way your dma routines worked, so I changed them.
Why have you not send me this change ? So i could add it to my SDK ?
No need to get incompatibel... It was a good idear...

> I changed the rest of your routines to more closely match my coding style.
Mhhh, removing my comments, and moving the { and } is not a big coding style different. So if my code was so bad, why have you used it ?

>It took me almost 2 days to convert your SDK over to ADS because of the way the code was written
It took me 6 Month creating AND Finding out the correct Values for some gp32 registers.
Try to figure out the LCD parameter on your own, and you see what i mean.

>the lack of prototypes, assuming the user was using GCC
Iam a linux/gcc user, and rob brown created a Windows port of my SDK, of couse there was a prototype file, you modified it for your needs.

> Working together is just not going to work out,
so if you cant work together with other coderz, its not my foult...

btw, loki666, created a SDK port to ADS some month ago, it would save you another 2 days...
 
Last edited by a moderator:
Hiya! i've kept a close eye on this thread and while im probably not entitled to my say thats never stopped me before :D

Squidge - your a good coder and i have little doubt you could easily make an SDK from scratch, but if your going to use somebody elses source-code its always better to check with them before you go public with the result, even with the best of intentions people can get very defensive when its something they've worked hard on developing.

i've spoken to a few people who have ported the SDK to ADS, all of which said it required very little work, so i feel calling it SquidgesSDK was a little too much for some peoples tastes which im sure you can apprechiate, considering over half of it was Mirko's code.

I suspect you were planning on rewriting most of the code eventually, but as it stands its still very much Mirko's work.

Wish you the best with your SDK

Pirotic
 
I don't remember removing comments. I never said your code was so bad, just not in my style.

As for the LCD registers, I did have the find the values by myself, as the code you have in grafik.c is wrong and doesn't work properly. The only reason it works to a degree is because the bios already sets up most of the registers for you.

Yes, there is a prototype file, but not all functions are present in it. Some functions assume return types and parameters in your code. I added prototypes for them and placed them into the prototypes file.

I can and do work with other coders (it's actually part of my job at work), but some people, like yourself, I just can't work with.

I did ask Mirko if I could port a version of his SDK to ADS. Whilst I didn't mention that it wouldn't be full port, I did at least ask first. After changing a few things, I decided best not to keep the original name.
 
Please, don't quarrel, you'll make me cry...

I feel respect for you two, please stop now, seriously. Everybody make mistakes: Squidge, I am a coder, don't talk about Mirko's work that way, it is horrible to receive that kind of comments, I know it very well (perhaps because people didn't believe I could make what I made).

Please stop ç_ç
 
Squidge posted on May 8 2004 at 11:44 PM said:
I don't remember removing comments. I never said your code was so bad, just not in my style.

As for the LCD registers, I did have the find the values by myself, as the code you have in grafik.c is wrong and doesn't work properly. The only reason it works to a degree is because the bios already sets up most of the registers for you.

Yes, there is a prototype file, but not all functions are present in it. Some functions assume return types and parameters in your code. I added prototypes for them and placed them into the prototypes file.

I can and do work with other coders (it's actually part of my job at work), but some people, like yourself, I just can't work with.

I did ask Mirko if I could port a version of his SDK to ADS. Whilst I didn't mention that it wouldn't be full port, I did at least ask first. After changing a few things, I decided best not to keep the original name.
> As for the LCD registers, I did have the find the values by myself, as the code you have in grafik.c is wrong and doesn't work properly. The only reason it works to a degree is because the bios already sets up most of the registers for you.

Ohh, there is no bios on my gp32, surprise surprise, it works very vell.
If youre sutch a good coder, its of couse no problem for you solving all bugs, and "keep them secret for you"... But hey, how did you find out all is wrong ? Are you still looking at my source ? Are you not starting at the beginning ? ( printing out the arm9.pdf ) ?

I can also tell you that the cpu setting is a litte wrong, i corrected it in my next release, and did i mention, that i will not tell you, what is wrong there...
 
Last edited by a moderator:
mr.mirko posted on May 9 2004 at 01:08 AM said:
Squidge posted on May 8 2004 at 11:44 PM said:
I don't remember removing comments. I never said your code was so bad, just not in my style.

As for the LCD registers, I did have the find the values by myself, as the code you have in grafik.c is wrong and doesn't work properly. The only reason it works to a degree is because the bios already sets up most of the registers for you.

Yes, there is a prototype file, but not all functions are present in it. Some functions assume return types and parameters in your code. I added prototypes for them and placed them into the prototypes file.

I can and do work with other coders (it's actually part of my job at work), but some people, like yourself, I just can't work with.

I did ask Mirko if I could port a version of his SDK to ADS. Whilst I didn't mention that it wouldn't be full port, I did at least ask first. After changing a few things, I decided best not to keep the original name.
> As for the LCD registers, I did have the find the values by myself, as the code you have in grafik.c is wrong and doesn't work properly. The only reason it works to a degree is because the bios already sets up most of the registers for you.

Ohh, there is no bios on my gp32, surprise surprise, it works very vell.
If youre sutch a good coder, its of couse no problem for you solving all bugs, and "keep them secret for you"... But hey, how did you find out all is wrong ? Are you still looking at my source ? Are you not starting at the beginning ? ( printing out the arm9.pdf ) ?

I can also tell you that the cpu setting is a litte wrong, i corrected it in my next release, and did i mention, that i will not tell you, what is wrong there...
No, I'm not still looking at your source code, that was when I couldn't get my program working correctly, and found the fault to be in your SDK. I fixed the fault and carried on.

I just find it strange that your LCD values had EXACTLY the same values as the original SDK (with the same incorrect setting on one of the registers), but in the wrong order, which seemed to me like you simply read the original values, and recreated them in c.

You are acting like I took your work and simply claimed it as my own, which is certainly not true.

But yes, lets leave it there.
 
Last edited by a moderator:
:unsure: i'm not sur those dicusion very good.

I'm personatly impressive with the Mirko SDK that is a really good work always in progress.

Actually i don't use gcc soo it's limited for me soo that why i'm interest in all ADS support for the SDK.

I think you all good in your work, maybe a solution for all the community can be found ? no. ;)
 
Status
Not open for further replies.
Back
Top