Note that 4.1-rc1 does not have the problem you describe, as the omap5 dsi support is not in the mainline.
I didn't look at omap5, if it has similar dt nodes etc, but how the numbers come for omap4:
The register in question is CONTROL_DSIPHY 0x4A100618.
The previous way was using omap4_ctrl_pad_writel with this define:
#define OMAP4_CTRL_MODULE_PAD_CORE_CONTROL_DSIPHY 0x0618
So presumably the control base is set to 0x4A100000.
The new code uses 'omap4_padconf_global' DT node as a base. So finding that from the omap4.dtsi, and looking at the offsets of that and its parent nodes, gives:
0x4a000000 + 0x100000 + 0x5a0
And the new offset in the display.c is:
#define OMAP4_DSIPHY_SYSCON_OFFSET 0x78
Which adds to:
0x4a000000 + 0x100000 + 0x5a0 + 0x78 = 0x4a100618
Tomi
On 10/05/15 15:22, Dr. H. Nikolaus Schaller wrote:
Hi Tomi, before I submit the attached patch, please can you check that my assumption how to convert the register offset is right (I have no experience with OMAP4 and 5 in this area).
BR, Nikolaus
Am 04.05.2015 um 09:10 schrieb Dr. H. Nikolaus Schaller hns@goldelico.com:
Hi Tomi,
Am 04.05.2015 um 08:10 schrieb Tomi Valkeinen tomi.valkeinen@ti.com:
On 30/04/15 18:27, Dr. H. Nikolaus Schaller wrote:
Hi Tomi, do you see the same error as I do:
arch/arm/mach-omap2/display.c: In function 'omap5_dsi_mux_pads': arch/arm/mach-omap2/display.c:161:2: error: implicit declaration of function 'omap4_ctrl_pad_readl' [-Werror=implicit-function-declaration] arch/arm/mach-omap2/display.c:164:2: error: implicit declaration of function 'omap4_ctrl_pad_writel' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors
See commit 23d34981c7e36fb609d3eaacf0a52a05d75ae008 which changed the omap4 function. Similar change needs to be done for omap5.
Yes, that is what I would expect (without knowing or understanding any details).
I'll update my patches when I find time.
Please! This is IMHO a blocking bug since we can’t even compile kernel.org 4.1-rc1 or -rc2 for OMAP5 to test other functions.
Best regards, NIkolaus