wl1271_warning() already appends a \n to the format, so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller hns@goldelico.com --- drivers/net/wireless/ti/wlcore/main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index 3a51ab116e79..ab34d41487d3 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -6065,16 +6065,16 @@ static int wl1271_register_hw(struct wl1271 *wl) }
if (oui_addr == 0xdeadbe && nic_addr == 0xef0000) { - wl1271_warning("Detected unconfigured mac address in nvs, derive from fuse instead.\n"); + wl1271_warning("Detected unconfigured mac address in nvs, derive from fuse instead."); if (!strcmp(pdev_data->family->name, "wl18xx")) { - wl1271_warning("This default nvs file can be removed from the file system\n"); + wl1271_warning("This default nvs file can be removed from the file system"); } else { - wl1271_warning("Your device performance is not optimized.\n"); - wl1271_warning("Please use the calibrator tool to configure your device.\n"); + wl1271_warning("Your device performance is not optimized."); + wl1271_warning("Please use the calibrator tool to configure your device."); }
if (wl->fuse_oui_addr == 0 && wl->fuse_nic_addr == 0) { - wl1271_warning("Fuse mac address is zero. using random mac\n"); + wl1271_warning("Fuse mac address is zero. using random mac"); /* Use TI oui and a random nic */ oui_addr = WLCORE_TI_OUI_ADDRESS; nic_addr = get_random_int();
"H. Nikolaus Schaller" hns@goldelico.com writes:
wl1271_warning() already appends a \n to the format, so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
"drivers: net:" in the title is unnecessary, but I can remove that.
Am 25.07.2018 um 08:40 schrieb Kalle Valo kvalo@codeaurora.org:
"H. Nikolaus Schaller" hns@goldelico.com writes:
wl1271_warning() already appends a \n to the format, so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
"drivers: net:" in the title is unnecessary, but I can remove that.
Ok, thanks! I wasn't aware of the precise subsystem tagging style here.
BR, Nikolaus
"H. Nikolaus Schaller" hns@goldelico.com writes:
Am 25.07.2018 um 08:40 schrieb Kalle Valo kvalo@codeaurora.org:
"H. Nikolaus Schaller" hns@goldelico.com writes:
wl1271_warning() already appends a \n to the format, so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
"drivers: net:" in the title is unnecessary, but I can remove that.
Ok, thanks! I wasn't aware of the precise subsystem tagging style here.
Yeah, subsystems can do it a bit differently. But you can easily check with git log the preferred style:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatch...
"H. Nikolaus Schaller" hns@goldelico.com wrote:
wl1271_warning() already appends a \n to the format, so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
Patch applied to wireless-drivers-next.git, thanks.
18dc5a4bbcc5 wlcore: remove duplicate \n for some warnings