Hi Andrey,
Am 07.07.2016 um 23:47 schrieb Andrey Utkin andrey_utkin@fastmail.com:
On Thu, Jul 07, 2016 at 08:47:34PM +0300, Andrey Utkin wrote:
On Thu, Jul 07, 2016 at 02:39:49PM +0200, H. Nikolaus Schaller wrote:
Hi Andrey, I think this is a good point where you can jump in and help to edit the driver patch.
Would that be ok?
I have prepared a -v3 branch (I have a GUI tool where I just needed one click to do that):
http://git.goldelico.com/?p=gta04-kernel.git;a=shortlog;h=refs/heads/work/hn...
Ok, jumping in. Thanks for turning to me for this. Expect some results in few hours.
A draft for the Changes note for [PATCH 0/n]:
Changes V3:
- coding style improvements
Done (something).
- added a mutex to properly serialize multiple calls to set_backlight
Done.
- use regmap defaults
TODO.
- improve DT parsing
In progress.
I think we can just pile up fixes and finally merge them into the first commit.
I hope I've fixed all points of review.
Not only those, but 200% more :)
I will look through them and comment (if necessary).
Please check my changes in work/andrey/leds/is31fl319x branch. http://git.goldelico.com/?p=gta04-kernel.git;a=shortlog;h=refs/heads/work/an...
Interesting that your checkpatch did report more than mine...
The last one, "led: is31fl319x: Replace all tabs in the middle of lines with spaces", may be controversal, but I believe it is right thing to do (i.e. to have tabs in the middle of lines is wrong thing to do). Honestly, I have an idea that indentation style currently enforced by checkpatch.pl is defective regarding abuse of tabs, and discouragement of spaces in exact places where they fit better than tabs. But that's unrelated; I think I'll raise this discussion in LKML some day :)
Yes, even tools like checkpatch are not perfect. For example the warning about missing Kconfig description. I had simply ignored that warning...
What is important is that checkpatch.pl likes how the driver looks after all of my changes.
I will merge & compile & test asap and if ok resubmit.
Thanks and BR, Nikolaus