Am 15.07.2016 um 14:21 schrieb Andrey Utkin andrey_utkin@fastmail.com:
On Fri, Jul 15, 2016 at 01:34:57PM +0200, H. Nikolaus Schaller wrote:
Works after re-adding the i2c_device_table entries. So the is31fl32 driver seems to be broken in that area.
Great. Well, without access to hardware I couldn't check this :)
This is why I thought it is easier if I do it for this step. Let's cross fingers that this was the last -v we have to submit...
I have added two more patches for the is31fl32...
Should we post them in the same patch set or separately (since they are bug fixes for a different driver)?
My vote is for two separate patches for that (so total count is 3).
I have put it into a separate feature branch now, so that it is easier to handle (post, modify, drop, cover-letter) that patch set:
http://git.goldelico.com/?p=gta04-kernel.git;a=shortlog;h=refs/heads/work/hn...
I'd change the commit message of last one:
- drop "drivers: ",
- drop stress on "*complete*",
- reword to avoid saying "driver.ko" as it looks strange,
- modprobed -> probed to avoid kind of tautology.
For the is31fl31 driver this is just an internal comment since we will squeeze everything into v4.
Like this:
led: is31fl32xx: define complete i2c_device_id table
Otherwise the driver module will not be automatically probed.
Good! Done.
BR, Nikolaus