Hi Andrey,
Am 13.07.2016 um 03:22 schrieb Andrey Utkin andrey_utkin@fastmail.com:
On Tue, Jul 12, 2016 at 10:29:05PM +0200, H. Nikolaus Schaller wrote:
Hi Andrey, maintainers seem to be very critical here :) And the simpler the driver (it is just 1 file) the more they comment on...
This is the point where I usually would give up and start to think: "Hey it's open source and I donate it to the community. If you want it different for reasons I would not care about, please feel free to do so!". But that is not what maintainers do...
Anyways, we have to fix these things.
Please simply reset --hard your branch to the -v4 branch I have just pushed:
http://git.goldelico.com/?p=gta04-kernel.git;a=shortlog;h=refs/heads/work/hn...
Then again, plese pile up all modifications for testing.
Please checkout branch work/andrey/leds/is31fl319x at git.goldelico.com/?p=gta04-kernel.git .
looks good and you were really quick!
I believe there is difference between supplying led_max_microamp of current to LED 100% of time and 2x led_max_microamp 50% of time (with PWM). But I hope Jacek knows better what he is suggesting and this is effectively harmless.
Thanks for pointing this out. It is not exactly the same and may be harmful. I have asked Jacek about this.
Let's await his comments before finalizing v4.
BR and thanks, Nikolaus