Hi Tomi,
Am 18.01.2018 um 16:54 schrieb Tomi Valkeinen tomi.valkeinen@ti.com:
On 18/01/18 17:49, H. Nikolaus Schaller wrote:
What is missing / has to be fixed in your opinion to integrate the OMAP5 TILER demo code written by Matthijs into mainline?
Or are you working yourself on a proper implementation?
I haven't looked at Matthijs implementation, but I have done some TILER fixes along the way. They're at least in the TI's kernel, I'm not sure if I have upstreamed them yet. Nothing for fbdev, though.
Ok.
It may not even be necessary to have fbdev rotation, just omapdrm mode on OMAP5. OMAP3 is completely fine (unless we add Matthijs' patch set.
But, overall, TILER rotation is not working. It is usable with CPU, but because of the TILER related errata, CPU access has been descoped, and is kind of unsupported.
This seems to be "fixed" by Matthijs patches in a satisfying way. At least for OMAP5. But I have no technical understanding about the details and what Matthijs are really doing. You are much more experts than me with TILER. I just know that it can be used for rotate while writing to a framebuffer or for reading to the panel. We just need reading to be fast and not resource hungry.
For OMAP3 it seems that just some code is not properly disabled on OMAP3, which makes trouble on multi-arch kernels but there is no need for rotation on OMAP3 (at least for our projects).
TILER would be usable with other IPs (SGX, DSP, VIP, VPE, etc), but the TILER 2D memory layout is not supported with dmabuf, so we have no means to use TILER 2D with other IPs.
Having the full list solved, does not seem to be of highest priority - except maybe the SGX. But SGX can probably do its own rotation easily.
So we are mainly looking for a working addition for OMAP5 for text display (default console) and X11/Wayland. Ideally such that Option "Rotate" "right" in xorg.conf simply works.
Do you think you can find time to take a look at Matthijs implementation and what he really is doing to get our demos working flawless (despite errata)?
BR and thanks, Nikolaus