Am 16.05.2018 um 21:50 schrieb Andy Shevchenko andy.shevchenko@gmail.com:
On Wed, May 16, 2018 at 8:01 PM, H. Nikolaus Schaller hns@goldelico.com wrote:
These mask bits are to be used to map the extended register addreseses (which are defined for an unsupported 8-bit pcal chip) to 16 and 24 bit chips (pcal6524).
Reviewed-by: Andy Shevchenko andy.shevchenko@gmail.com Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
drivers/gpio/gpio-pca953x.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 2b667166e855..c0eb679e60d4 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -56,6 +56,10 @@ #define PCAL6524_DEBOUNCE 0x2d
#define PCA_GPIO_MASK 0x00FF
+#define PCAL_GPIO_MASK GENMASK(4, 0) +#define PCAL_PINCTRL_MASK (~PCAL_GPIO_MASK)
I give second thought about it, and think either plain values, or second converted to its own explicit GENMASK would be better.
(most confusing part to me is unknowness of the side of PINCTRL part in the mask)
I see.
Then, I'd also prefer plain values.
If ok, I can send a v7 tomorrow.
BR, Nikolaus