Am Sat, 25 Feb 2017 12:55:34 +0100 hat "H. Nikolaus Schaller" hns@goldelico.com geschrieben:
Hi,
Putting this on the kernel list, as others might think different about that than me :)
I noticed the logo leds have red/green swapped.
Oh. Have checked them individually and you are right.
- DT entry seems to be ok
- is31fl3196 isn't swapping bits either
- unlikely that it is the driver
- schematics are ok
- footpring is ok, pin numbers are ok
- LED module can't be mounted upside down (would reverse all pins and
Anode isn't connected correctly so none of the LEDs would work)
Remains only one potential reason: that the LEDs inside the OVSRRGBCC3 LED module are connected differently than what our component library assumes. This is the only type of mistake that an automatic design rules check can never detect and which is carried from there into the PCB layout.
Yes, R-G-B should be Pin 1-2-3 according to data sheet while we have 2-1-3!
So thanks for noticing!
We can now either modify the hardware or simply hack the DT names...
Problem of fixing the hardware is that we create two different variants which need different Device Tree files to show the same colors. So I'd propose to leave the hardware, make a note in the schematics PDFs and hack the DT.
@ED: what would you prefer?
Well, I personally don't see any problem if we change the names in the DT files. After all, the DT files are Pyra-Specific, so that shouldn't have any negative effect, should it?
Can anyone think of a reason NOT to rename it in the DT file?