On 12 February 2017 at 12:57, H. Nikolaus Schaller hns@goldelico.com wrote:
So your patch is doing the right thing and I have applied it so that you can rebase
Done :-)
It is sometimes a big hack. My approach is to be minimally invasive to upstream code, i.e. try to add things to new files and #include maintained code where possible.
Yeah, I tend to lose overview in the maze of #includes in u-boot config though... TI is really overdue to properly switch over to the Kconfig model.
To be fair, configs/ti_omap5_common.h is *supposed* to be the common include for omap5-based targets. Including the uevm and #undefing parts seems icky to me, and risks becoming more wrong if more details of the uevm are spelled out in detail. As far as "maintained" goes, it clearly lags behind dra7 though...
Do we need different U-Boot binaries for LPAE and non-LPAE, like for the
Kernel?
I'm pretty sure LPAE u-boot can start non-LPAE kernel and vice versa. My impression is that the main reason for an LPAE u-boot is because it's needed for hypervisor mode (which is always LPAE iirc).
Or can we simply enable LPAE for everyone?
Assuming you mean all pyra (or more generally Letux Cortex-A15) users, it's fine to enable LPAE for everyone. Non-LPAE kernel *might* be more efficient but I haven't evaluated this. I don't think there's any reason to run a non-LPAE u-boot, assuming the LPAE version works (haven't tried it yet).
Interesting feature. Have to look how it works.
=> ums 0 mmc 1:0
(the :0 indicates whole card instead of just a partition)
And, IMHO, a boot loader should be stabilized once and then not be touched for years (or you invite a lot of problems into kernel and user support).
On the beaglebone I never worry much about it since I don't need anything from it other than booting the kernel, and if it's not working right I can replace easily via usb. It's not the critical component it is on some other platforms since the ROM bootloader already offers sufficient alternatives ways of booting.
Having said that though, I haven't yet seen the ROM bootloader appear as usb device on the pyra like it does on the uEVM. I'm going to give that another try...
Matthijs