Hi Jonathan,
Le mar. 28 avril 2020 à 15:58, Jonathan Bakker xc-racer2@live.ca a écrit :
Hi all,
On 2020-04-28 2:39 p.m., Jonathan Bakker wrote:
Hi Krzysztof,
On 2020-04-27 8:46 a.m., Krzysztof Kozlowski wrote:
On Sun, Apr 26, 2020 at 07:57:12AM -0700, Jonathan Bakker wrote:
Hi Paul,
On 2020-04-26 5:56 a.m., Paul Cercueil wrote:
Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller hns@goldelico.com a écrit :
From: Jonathan Bakker xc-racer2@live.ca
All s5pv210 devices have a PowerVR SGX 540 (revision 120) attached.
There is no external regulator for it so it can be enabled by default.
Signed-off-by: Jonathan Bakker xc-racer2@live.ca Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
arch/arm/boot/dts/s5pv210.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 2ad642f51fd9..abbdda205c1b 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -512,6 +512,19 @@ vic3: interrupt-controller@f2300000 { #interrupt-cells = <1>; };
gpu: gpu@f3000000 {compatible = "samsung,s5pv210-sgx540-120";This should not pass the bindings check because you missed last compatibles.
Thanks for pointing that out, I'll add it and make sure it passes the bindings check.
reg = <0xf3000000 0x10000>;interrupt-parent = <&vic2>;interrupts = <10>;clock-names = "core";clocks = <&clocks CLK_G3D>;assigned-clocks = <&clocks MOUT_G3D>, <&clocksDOUT_G3D>;
assigned-clock-rates = <0>, <66700000>;assigned-clock-parents = <&clocks MOUT_MPLL>;What are these clocks for, and why are they reparented / reclocked?
Shouldn't they be passed to 'clocks' as well?
-Paul
The G3D clock system can have multiple parents, and for stable operation it's recommended to use the MPLL clock as the parent (which in turn is actually a mux as well). MOUT_G3D is simply the mux for CLK_G3D (SGX core clock), DOUT_G3D is the divider. DOUT_G3D could equally be CLK_G3D (and probably should be, for readability) as CLK_G3D is simply the gate and DOUT_G3D is the divider for it.
Good point, it should be CLK_G3D instead of DOUT. Can you fix this as well?
Yep, will do. Nikolaus, I'll send you an updated patch to include.
How are assigned-clocks handled in the yaml DT schema? When running make dtbs_check, I end up with messages such as
arch/arm/boot/dts/s5pv210-aquila.dt.yaml: gpu@f3000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
Do they need to explicitly be listed as valid entries?
The assigned-* can also be moved inside the node of the clocks provider. I would say it makes more sense to have them there.
-Paul