-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi everybody! I had a look at updating pnd_make.sh and attached both a diff as well as the full version. The list of changes: * Add decent argument parsing. * Add support for schema validation. * Add support for additional switches: * usage of "long" parameter names * --genpxml define the script to be used to generate a pxml file * --schema / -s define the schema file to be used * --help / -h show a list of possible parameters as well as explanations of what they actually mean * Add colored output. * General cleanup.
Cheers, Nils Kneuper aka Ivanovic
Hi,
tested from my emu build Makefile and it seems to work fine. One comment about the schema thing, it's a bit inconvenient to specify it every time in command line or put it to the working dir (which is set to projects root for me), could you also look for it in the same dir where the script is located? Something like `dirname $0`/PXML_schema.xsd maybe.
Gražvydas
On Sun, Mar 6, 2011 at 3:24 AM, Nils Kneuper crazy-ivanovic@gmx.net wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi everybody! I had a look at updating pnd_make.sh and attached both a diff as well as the full version. The list of changes:
- Add decent argument parsing.
- Add support for schema validation.
- Add support for additional switches:
* usage of "long" parameter names * --genpxml define the script to be used to generate a pxml file * --schema / -s define the schema file to be used * --help / -h show a list of possible parameters as well as explanations of what they actually mean
- Add colored output.
- General cleanup.
Cheers, Nils Kneuper aka Ivanovic -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux)
iEYEARECAAYFAk1y4jgACgkQfFda9thizwWo+ACgly49vcglq+aFCFlEIZQrGLNl d1EAni6/75Njd6U78WdeMExrOjcf/ICa =3nNm -----END PGP SIGNATURE-----
Firmware-dev mailing list Firmware-dev@openpandora.org http://openpandora.org/cgi-bin/mailman/listinfo/firmware-dev
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 06.03.2011 17:01, schrieb Grazvydas Ignotas:
tested from my emu build Makefile and it seems to work fine. One comment about the schema thing, it's a bit inconvenient to specify it every time in command line or put it to the working dir (which is set to projects root for me), could you also look for it in the same dir where the script is located? Something like `dirname $0`/PXML_schema.xsd maybe.
Of course this can be done. That is: I have intentionally put the "default value" into a variable at the top which makes it easy to edit this setting. Anything else that could/should be changed/fixed? Cheers, Nils Kneuper aka Ivanovic
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 06.03.2011 17:46, schrieb Nils Kneuper:
Am 06.03.2011 17:01, schrieb Grazvydas Ignotas:
tested from my emu build Makefile and it seems to work fine. One comment about the schema thing, it's a bit inconvenient to specify it every time in command line or put it to the working dir (which is set to projects root for me), could you also look for it in the same dir where the script is located? Something like `dirname $0`/PXML_schema.xsd maybe.
Of course this can be done. That is: I have intentionally put the "default value" into a variable at the top which makes it easy to edit this setting. Anything else that could/should be changed/fixed?
Committed those changes to git. Besides the schema change I also added some more validity checks and stuff like this. Have a look at the commit message [1] for the changelog. Further testing of the changes including mentioning possible problems is welcome.
Known problems: * It is possible to generate a PXML.xml file that will not work with pre Hotfix6 since the schema does accept a pnd without <title> at the root of the <application> block. At the moment the packager has to check for this himself since pnd_make.sh is not able to warn about this. * The icon provided can be any kind of file. Are there some limits/file types that I could check for to make sure that only a "valid" icon is appended? At the moment it is only checked that the supplied icon is actually a file.
Cheers, Nils Kneuper aka Ivanovic
[1] http://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-libraries.git;a=comm...