On Sat, 27 Aug 2011, Jari Vetoniemi wrote:
# I fscked the patches for various reason, so they are all like they are now.. # Should still apply on the fresh git. # # I'll forward this message I originally sent to skeezix, since there # have been no activity:
yes, sorry, RL has my ass in a basket :P
Is this patch known good then? You've tested it a few rounds in Panorama and milky, so this patch is tested suffuciently to go in?
# ---------- Forwarded message ---------- # # This patch should apply on the fresh clone of # http://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-libraries.git;a=summ... # # It adds few stuff more for package support, and the last patch fixes # leaks on libpnd discovery. # However the discovery example will still leak however, as it does not # destroy disco objects. I can send patch to it too later, as some # people might use it as reference.
yeah, the disco test tool was mostly just to work the lib and show how to pull, so probably shoudl have added the cleanup in case someone uses it; patch away!
# I kinda screwed the patches, but they should still apply. So make sure # you don't apply the old ones :) # # http://dl.dropbox.com/u/15640770/libpnd_patches.tar
Is this a complete 'should apply' group? I've got your latest email still, but if this is the newest one-pack thats good, so I don't use your bad patches.
You'd sent me a few and then lateer said some were bad, so I used it as an opportunity to be careful -- let you vet your latest patch before applying it. (You're sort of sending them to me before they're well tested, so I need necessarily sit on them for awhile before applying, right? ;)
Certainly though, with sebt3 busy right now, and me busy right now, I guess the current libpnd committer is Ivanovic; if he is also busy, we may need to coopy another committer.
The mailing list is probably the better place to submit the patches, than just me, right nowe. (1 month to twins coming, give or take, so I'm distracted.)
For patch submissions, they shoudl include notes as to the goal of the patches and a list of tests performed ;)
# Also why do I keep trying to use vim bindings on gmail?
Becasue you're not using Emacs :)
jeff
-- If everyone would put barbecue sauce on their food, there would be no war.