I've looked at these patches and they look ok, except for adding new fields to existing structures, won't that break binary compatibility with existing apps that use libpnd? Granted, stuff that comes with firmware will get recompiled and be ok, but maybe there is something else. You could probably add new stuff at the end of the structures to avoid this problem. There is also minor indentation differences between your and surrounding old code.
So I've applied patch 3 and left out all *_version_* stuff. For this you need to either fix it or distract skeezix from his twins and make him say modifying those structs is ok. You'll also need to rebase and resend parts of patch3 that I left out and probably merge all *_version_* patches, there is no real need for splitting of what's left of them.
On Sat, Aug 27, 2011 at 3:37 AM, Jari Vetoniemi mailroxas@gmail.com wrote:
I fscked the patches for various reason, so they are all like they are now.. Should still apply on the fresh git.
I'll forward this message I originally sent to skeezix, since there have been no activity:
---------- Forwarded message ----------
This patch should apply on the fresh clone of http://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-libraries.git;a=summ...
It adds few stuff more for package support, and the last patch fixes leaks on libpnd discovery. However the discovery example will still leak however, as it does not destroy disco objects. I can send patch to it too later, as some people might use it as reference.
I kinda screwed the patches, but they should still apply. So make sure you don't apply the old ones :)
http://dl.dropbox.com/u/15640770/libpnd_patches.tar
Also why do I keep trying to use vim bindings on gmail? _______________________________________________ Firmware-dev mailing list Firmware-dev@openpandora.org http://openpandora.org/cgi-bin/mailman/listinfo/firmware-dev