On Sat, 27 Aug 2011, Grazvydas Ignotas wrote:
# I've looked at these patches and they look ok, except for adding new # fields to existing structures, won't that break binary compatibility # with existing apps that use libpnd? Granted, stuff that comes with # firmware will get recompiled and be ok, but maybe there is something # else. You could probably add new stuff at the end of the structures to # avoid this problem. # There is also minor indentation differences between your and # surrounding old code.
Generally new struct additions should always be at the bottom; for a couple patches that have come in, I think I massaged them that way.
On the other hand, few people have leveraged internal structures of libpnd too much, so we can usually get away with such things, but still best avoided, but disco_t is the sensitive interface struct.
# So I've applied patch 3 and left out all *_version_* stuff. For this # you need to either fix it or distract skeezix from his twins and make # him say modifying those structs is ok. You'll also need to rebase and # resend parts of patch3 that I left out and probably merge all # *_version_* patches, there is no real need for splitting of what's # left of them.
Ah, many thanks notaz!
We still need to go through the exercise of breaking libpnd into libpnd and libpandora -- on the off chance pnd-related stuff may be useful off-pandora, and to keep Pandora specific stuff in one place, but I think I don't wan tot tackle such a thing ('rock the boat') at this point for myself. (I'm "on call", and not interested in leaving things in a broken state.)
jeff
-- If everyone would put barbecue sauce on their food, there would be no war.