From crazy-ivanovic@gmx.net Tue Mar 8 14:47:23 2011 From: Nils Kneuper To: firmware-dev@openpandora.org Subject: Re: [Firmware-dev] new/updated pnd_make.sh Date: Tue, 08 Mar 2011 14:47:21 +0100 Message-ID: <4D763369.1080808@gmx.net> In-Reply-To: <4D73BA5F.7060407@gmx.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4359078335037922901==" --===============4359078335037922901== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 06.03.2011 17:46, schrieb Nils Kneuper: > Am 06.03.2011 17:01, schrieb Grazvydas Ignotas: >> tested from my emu build Makefile and it seems to work fine. One >> comment about the schema thing, it's a bit inconvenient to specify it >> every time in command line or put it to the working dir (which is set >> to projects root for me), could you also look for it in the same dir >> where the script is located? Something like `dirname >> $0`/PXML_schema.xsd maybe. >=20 > Of course this can be done. That is: I have intentionally put the "default > value" into a variable at the top which makes it easy to edit this setting. > Anything else that could/should be changed/fixed? Committed those changes to git. Besides the schema change I also added some m= ore validity checks and stuff like this. Have a look at the commit message [1] for the changelog. Further testing of the changes including mentioning possible problems is welcome. Known problems: * It is possible to generate a PXML.xml file that will not work with pre Hotf= ix6 since the schema does accept a pnd without at the root of the <application> block. At the moment the packager has to check for this himself since pnd_make.sh is not able to warn about this. * The icon provided can be any kind of file. Are there some limits/file types that I could check for to make sure that only a "valid" icon is appended? At = the moment it is only checked that the supplied icon is actually a file. Cheers, Nils Kneuper aka Ivanovic [1] http://git.openpandora.org/cgi-bin/gitweb.cgi?p=3Dpandora-libraries.git;a=3Dc= ommit;h=3D4a0c71eb2dfb1f9d67a4a6c5ed0dd68c0c76f5c2 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iEYEARECAAYFAk12M2kACgkQfFda9thizwXFjgCfYRf4qzSTXafFnyo3ls9wc1BS 3KgAmwet82TFSr5NGfQcDU7RqIeXYsFg =3Diahv -----END PGP SIGNATURE----- --===============4359078335037922901==--